-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HGCAL Layer Clusters visualization in Fireworks - Backport CMSSW_13_2_X #42563
Fix HGCAL Layer Clusters visualization in Fireworks - Backport CMSSW_13_2_X #42563
Conversation
A new Pull Request was created by @waredjeb (Wahid Redjeb) for CMSSW_13_2_X. It involves the following packages:
@cmsbuild, @makortel, @Dr15Jones, @alja can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
backport of #42519 |
Hi @perrotta. This PR is meant to fix a problem created with #41589, which If understand correctly is in CMSSW_13_2_X. I'm wondering whether backporting this fix to CMSSW_13_1 could have any effects? |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed2fe8/34312/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR is a backport of #42519
Description
This PR fixes the HGCAL Layer Clusters (CaloClusters) visualization in Fireworks. The Layer Clusters collection changed name in CMSSW_13_2_X in #41589
With this PR Fireworks will check if the
hgcalLayerClusters
collection is present, if not it will try to read thehgcalMergeLayerClusters
collection, in this way it is possible to read files produced before CMSSW_13_2_X with new releases.Validation
Validation